whenever i try to add a new payment method it makes me log i into my apple id and it says payment method declined

If your payment method is declined in the App Store or iTunes Store, see -> 

If your payment method is declined in the App Store or iTunes Store - Apple Support

⤵️

How to complete your purchase if a payment failed or was declined

1. On your iPhone or iPad, open the Settings app.
2. Tap your name.
3. Tap Payment & Shipping.
4. Add a different payment method and remove the old one. 
5. Try to complete your purchase.

If you still can't make a purchase

• You might have an unpaid order. Learn how to pay an unpaid order.
• Contact your financial institution. 
  • You might need to ask your financial institution to allow international purchases on your debit or credit card.
  • If you want to know why a debit card, credit card, or other payment method was declined, speak with your financial institution. Apple doesn't have information about why the payment method was declined.
• In some countries and regions, your payment method might be declined because of changes to local law. Learn about billing and purchases in Europe or what to do if your card is declined in India.
• Still need help? Contact Apple Support.

See the following Apple articles:

Payment methods you can use with your Apple ID

Payment methods you can use with your Apple ID – Apple Support (UK)

fyi: Not all credit & debit cards seem to work with App Store / iTunes Store, try a different one, or preferably a credit card. If your card is not accepted as a paymenf method, you need to contact your bank.

What you can buy with your Apple Gift Card or Apple Account balance

What you can buy with your Apple Gift Card or Apple Account balance – Apple Support (UK)

⤵️

• You can't use your Apple Account balance to send gifts or gift cards.
• If you use Family Sharing, your family members can't spend your Apple Account balance. Funds that you add to your Apple Account balance are only available to you. Find out more about how purchases are billed to your Apple Account balance.
• Some purchases might require you to have a credit card on file, even if you use your Apple Account balance to make the purchase.

Remove a payment method from your Apple ID

Remove a payment method from your Apple ID - Apple Support 

⤵️

If you can't remove a payment method

If you have subscriptions like iCloud+, have an unpaid balance, or you use purchase sharing, you must keep at least one payment method on file.

• Do you have a subscription? You can cancel iCloud+ and cancel other subscriptions from Apple. When your subscription period is over, remove your payment method.
• If you're in a Family Sharing group and you use purchase sharing, the family organizer must have a payment method on file. If you're the family organizer, turn off purchase sharing, then remove the payment method.
• If you have an unpaid balance, you might not be able to remove a payment method. Instead, change your payment method.
• If you still can't remove a payment method, contact Apple Support.

If you need to change or update your Apple ID payment method

If you need to change or update your Apple ID payment method - Apple Support

Add a payment method to your Apple ID -> Add a payment method to your Apple ID – Apple Support (UK)

• If you want to change your card, you need to add first the new card, then remove the old card.
• or if you use your Apple Account balance, you need to set your Apple Account balance as your default payment.

Add money to your Apple Account balance -> Add money to your Apple Account balance - Apple Support

If you're still unable to update your payment method, Contact Apple Support.

If you have a valid payment method on file, instead of buying or order an App Store & iTunes gift card, you can Add money to your Apple Account balance anytime, no gift card needed, see -> Apple Gift Card - Apple (UK)

If you have followed all the steps and instructions and if you still need help, get support from Apple directly -> Get Support or call Apple in your region see -> Contact Apple for support and service or check -> here for more support and assistance.