Repeated sign-in popups on iCloud for PC after password change

I am signed into icloud on my iphone ipad and pc after recently changing the password, but on PC the sign up window pops up, I fill in password, then the verification number, then it just shows sign in window again, (repeatedly every minute) I appear to be signed in as I can see my name info etc, though it does not show my devices (on pc) although photos say uploading item without changing and idrive says it has not updated in 20 days .It is stopping me from doing my work and I do not know how to fix it without losing all my pics etc on pc, I tried saying forgot password but that just meant i had to do that on iphone and nothing seemed to change on pc ..please help

[Re-Titled by Moderator]