if I upgrade icloud storage on 1 device, is it good on all my devices?

Yes, as long as you are using the same Apple ID on all devices.

iCloud storage is tied to your Apple ID, not a specific device.

Any device logged in to the same Apple ID for iCloud can access the purchased storage space.

It what we’re here for. 👍🐈