How can I securely back up my photos from iCloud?

I am pretty sure my friend was trying to clone my phone last weekend. It was unlocked cuz I was at home, when I came out of a room she was standing by my phone with hers over it. What can she get off by cloning? Pictures, passwords, contacts, Facebook/Messenger/Instagram? I am sure she wanted a phone number but she would not find it. But she would be one to call this person on Messenger. I have know this person for 30 plus years. We a quite break between the years being married and kids and all. But people change, I am more paranoid then ever. My phone will click like it’s taking a picture. Then is there a way where you can turn off the option to clone or not? It’s against the law to voice record someone on the phone unless u tell u are or if there is this tiny little beep which is very hard to hear. Businesses do this that way. I know she was trying to get me to look at her to take a photo and she kept asking me stupid questions like how u do when I set up Siri. Of course I played dumb and would cough, the tone of my voice or just ignore her. Now my Apple ID is completely shut out from me. I was able to get in here. So, I don’t know to what extent she can go to get info. Even ur family , best friend are no longer safe to be “that person” for u. We are on our own. If I get a new phone should I just enter my contacts in manually? What about all the hundreds of photos on the cloud. How can I save those? To a flash drive, then hook up to new phone? Then last but least. Do u have to have a virus thingy (drawing a blank) like Norton to add on ur iPhone. I see all these adds but how do u know what is good n honest. Frustrated as heck. TIA

[Re-Titled by Moderator]